Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1985#discussion_r63509887
  
    --- Diff: 
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/PartialLossFunction.scala
 ---
    @@ -47,21 +47,106 @@ object SquaredLoss extends PartialLossFunction {
     
       /** Calculates the loss depending on the label and the prediction
         *
    -    * @param prediction
    -    * @param label
    -    * @return
    +    * @param prediction The predicted value
    +    * @param label The true value
    +    * @return The loss
         */
       override def loss(prediction: Double, label: Double): Double = {
         0.5 * (prediction - label) * (prediction - label)
       }
     
       /** Calculates the derivative of the [[PartialLossFunction]]
         *
    -    * @param prediction
    -    * @param label
    -    * @return
    +    * @param prediction The predicted value
    +    * @param label The true value
    +    * @return The derivative of the loss function
    --- End diff --
    
    Good code completion, thanks :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to