[
https://issues.apache.org/jira/browse/FLINK-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302011#comment-15302011
]
ASF GitHub Bot commented on FLINK-3908:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2007#issuecomment-221858427
Thanks for addressing this bug!
How about slightly changing the names of the methods:
- The method that resets the error state and parses would be called
`resetErrorStateAndParse(...)`. That would make it clear what happens.
- The `parseFieldImpl(...)` could be kept as `parseField(...)`
- The `GenericCsvInputCormat` would call the
`resetErrorStateAndParse(...)` method.
Other than that, solution looks good!
> FieldParsers error state is not reset correctly to NONE
> -------------------------------------------------------
>
> Key: FLINK-3908
> URL: https://issues.apache.org/jira/browse/FLINK-3908
> Project: Flink
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Reporter: Flavio Pompermaier
> Assignee: Flavio Pompermaier
> Labels: parser
>
> If during the parse of a csv there's a parse error (for example when in a
> integer column there are non-int values) the errorState is not reset
> correctly in the next parseField call. A simple fix would be to add as a
> first statement of the {{parseField()}} function a call to
> {{setErrorState(ParseErrorState.NONE)}} but it is something that should be
> handled better (by default) for every subclass of {{FieldParser<T>}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
