[
https://issues.apache.org/jira/browse/FLINK-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310486#comment-15310486
]
ASF GitHub Bot commented on FLINK-3908:
---------------------------------------
Github user fpompermaier commented on the issue:
https://github.com/apache/flink/pull/2007
I think that leaving the responsibility of calling
resetErrorStateAndParse() to "consumers" of FieldParser is really a bad idea.
Isn't safer to force its call using the strategy adopted in this PR (i.e. keep
the real implementation in parseFieldImpl and use parseField to call
resetErrorStateAndParse before it)?
> FieldParsers error state is not reset correctly to NONE
> -------------------------------------------------------
>
> Key: FLINK-3908
> URL: https://issues.apache.org/jira/browse/FLINK-3908
> Project: Flink
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Reporter: Flavio Pompermaier
> Assignee: Flavio Pompermaier
> Labels: parser
>
> If during the parse of a csv there's a parse error (for example when in a
> integer column there are non-int values) the errorState is not reset
> correctly in the next parseField call. A simple fix would be to add as a
> first statement of the {{parseField()}} function a call to
> {{setErrorState(ParseErrorState.NONE)}} but it is something that should be
> handled better (by default) for every subclass of {{FieldParser<T>}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
