[
https://issues.apache.org/jira/browse/FLINK-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302107#comment-15302107
]
ASF GitHub Bot commented on FLINK-3908:
---------------------------------------
Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/2007#issuecomment-221880071
I don't understand :(
Assuming that `reset` could be renamed as `resetErrorStateAndParse`, the
other 2 suggestions cannot be applied to my current implementation: if I want
to rename `parseFieldImpl` to `parseField` I should overload somehow the method
otherwise that's not possible because there's already an abstract method called
parseField with the same sign..
Wrt leaving the responsibility to reset the state of the parsers to the
classes calling the parseField is quite dangerous IMHo (as you said in
"GenericCsvInputCormat would call the resetErrorStateAndParse").
Am I misunderstanding something?
> FieldParsers error state is not reset correctly to NONE
> -------------------------------------------------------
>
> Key: FLINK-3908
> URL: https://issues.apache.org/jira/browse/FLINK-3908
> Project: Flink
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Reporter: Flavio Pompermaier
> Assignee: Flavio Pompermaier
> Labels: parser
>
> If during the parse of a csv there's a parse error (for example when in a
> integer column there are non-int values) the errorState is not reset
> correctly in the next parseField call. A simple fix would be to add as a
> first statement of the {{parseField()}} function a call to
> {{setErrorState(ParseErrorState.NONE)}} but it is something that should be
> handled better (by default) for every subclass of {{FieldParser<T>}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
