JingGe commented on a change in pull request #17995:
URL: https://github.com/apache/flink/pull/17995#discussion_r763033997
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java
##########
@@ -161,6 +189,16 @@ public static void setAsContext(
final boolean suppressSysout) {
StreamExecutionEnvironmentFactory factory =
conf -> {
+ final List<JobValidationError> errors = new ArrayList<>();
+ final boolean allowConfigurations =
+ configuration.getBoolean(
+
DeploymentOptions.ALLOW_CLIENT_JOB_CONFIGURATIONS);
+ if (!allowConfigurations && !conf.toMap().isEmpty()) {
+ conf.toMap()
+ .forEach(
+ (k, v) ->
+ errors.add(new
ConfigurationNotAllowedError(k, v)));
Review comment:
yes, I thought the requirement was no configuration will be allowed by
the user at all. If this is right, showing error messages for every config kvs
might become to be noises to the user who would need more effort to walk
through all these errors and finally found that none customer config is
allowed, no matter which one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
