XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r780344263
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java
##########
@@ -244,11 +244,13 @@ public void cleanupJobData(JobID jobID) throws Exception {
protected abstract JobGraphStore createJobGraphStore() throws Exception;
/**
- * Create the registry that holds information about whether jobs are
currently running.
+ * Create the store that holds completed job results.
*
- * @return Running job registry to retrieve running jobs
+ * @return Job result store to retrieve completed jobs
*/
- protected abstract RunningJobsRegistry createRunningJobsRegistry();
+ protected JobResultStore createJobResultStore() {
+ return new EmbeddedJobResultStore();
Review comment:
I removed this method entirely. The `JobResultStore` is passed in as a
parameter through the constructor now. The actual implementations of
`AbstractHaServices` are forced to instantiate it and pass it through the
parent class constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
