XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r780397929



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/zookeeper/ZooKeeperHaServicesTest.java
##########
@@ -235,8 +235,7 @@ private void runCleanupTestWithJob(
             final LeaderElectionService jobManagerLeaderElectionService =
                     
zooKeeperHaServices.getJobManagerLeaderElectionService(jobId);
 
-            final RunningJobsRegistry runningJobsRegistry =
-                    zooKeeperHaServices.getRunningJobsRegistry();
+            final JobResultStore jobResultStore = 
zooKeeperHaServices.getJobResultStore();

Review comment:
       good catch. We should remove it. The test is about cleaning up the 
znodes. It's just about creating some paths. The integration of this component 
into the test becomes obsolete with the `JobResultStore` replacing the 
`RunningJobRegistry` since no ZK-related artifacts are created by the 
`JobResultStore`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to