XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r780354067
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobPersistenceComponentFactory.java
##########
@@ -18,13 +18,22 @@
package org.apache.flink.runtime.jobmanager;
-/** Factory for {@link JobGraphStore}. */
-public interface JobGraphStoreFactory {
+import org.apache.flink.runtime.highavailability.JobResultStore;
+
+/** Factory for components that are responsible for persisting a job for
recovery. */
+public interface JobPersistenceComponentFactory {
/**
* Creates a {@link JobGraphStore}.
*
* @return a {@link JobGraphStore} instance
*/
- JobGraphStore create();
+ JobGraphStore createJobGraphStore();
+
+ /**
+ * Creates {@link JobResultStore} instances.
+ *
+ * @return {@code JobResultStore} instances.
Review comment:
I prefer having only one link per JavaDoc paragraph (like it's done in
Wikipedia) to reduce the distraction caused by link formatings when reading it.
I aligned the JavaDoc of both methods in `JobPersistenceComponentFactory`
accordingly. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
