[ 
https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422617#comment-15422617
 ] 

ASF GitHub Bot commented on FLINK-4253:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2342#discussion_r74918068
  
    --- Diff: docs/setup/config.md ---
    @@ -285,7 +285,7 @@ of the JobManager, because the same ActorSystem is 
used. Its not possible to use
     
     ## High Availability Mode
     
    -- `recovery.mode`: (Default 'standalone') Defines the recovery mode used 
for the cluster execution. Currently, Flink supports the 'standalone' mode 
where only a single JobManager runs and no JobManager state is checkpointed. 
The high availability mode 'zookeeper' supports the execution of multiple 
JobManagers and JobManager state checkpointing. Among the group of JobManagers, 
ZooKeeper elects one of them as the leader which is responsible for the cluster 
execution. In case of a JobManager failure, a standby JobManager will be 
elected as the new leader and is given the last checkpointed JobManager state. 
In order to use the 'zookeeper' mode, it is mandatory to also define the 
`recovery.zookeeper.quorum` configuration value.
    +- `high-availability`: (Default 'none') Defines the recovery mode used for 
the cluster execution. Currently, Flink supports the 'none' mode where only a 
single JobManager runs and no JobManager state is checkpointed. The high 
availability mode 'zookeeper' supports the execution of multiple JobManagers 
and JobManager state checkpointing. Among the group of JobManagers, ZooKeeper 
elects one of them as the leader which is responsible for the cluster 
execution. In case of a JobManager failure, a standby JobManager will be 
elected as the new leader and is given the last checkpointed JobManager state. 
In order to use the 'zookeeper' mode, it is mandatory to also define the 
`recovery.zookeeper.quorum` configuration value.  Previously this config was 
named 'recovery.mode' and the default config was 'standalone'.
     
     - `recovery.zookeeper.quorum`: Defines the ZooKeeper quorum URL which is 
used to connet to the ZooKeeper cluster when the 'zookeeper' recovery mode is 
selected
    --- End diff --
    
    Docs not updated (same for jobmanager_high_availability.md)


> Rename "recovery.mode" config key to "high-availability"
> --------------------------------------------------------
>
>                 Key: FLINK-4253
>                 URL: https://issues.apache.org/jira/browse/FLINK-4253
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: ramkrishna.s.vasudevan
>
> Currently, HA is configured via the following configuration keys:
> {code}
> recovery.mode: STANDALONE // No high availability (HA)
> recovery.mode: ZOOKEEPER // HA
> {code}
> This could be more straight forward by simply renaming the key to 
> {{high-availability}}. Furthermore, the term {{STANDALONE}} is overloaded. We 
> already have standalone cluster mode.
> {code}
> high-availability: NONE // No HA
> high-availability: ZOOKEEPER // HA via ZooKeeper
> {code}
> The {{recovery.mode}} configuration keys would have to be deprecated before 
> completely removing them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to