[
https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422618#comment-15422618
]
ASF GitHub Bot commented on FLINK-4253:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2342#discussion_r74918209
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -77,7 +77,7 @@
/**
* Shutdown hook thread to ensure deletion of the storage directory (or
<code>null</code> if
- * the configured recovery mode does not equal{@link
RecoveryMode#STANDALONE})
+ * the configured recovery mode does not equal{@link RecoveryMode#NONE})
--- End diff --
I think we could should also rename this enum to `HighAvailabilityMode` or
so.
> Rename "recovery.mode" config key to "high-availability"
> --------------------------------------------------------
>
> Key: FLINK-4253
> URL: https://issues.apache.org/jira/browse/FLINK-4253
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: ramkrishna.s.vasudevan
>
> Currently, HA is configured via the following configuration keys:
> {code}
> recovery.mode: STANDALONE // No high availability (HA)
> recovery.mode: ZOOKEEPER // HA
> {code}
> This could be more straight forward by simply renaming the key to
> {{high-availability}}. Furthermore, the term {{STANDALONE}} is overloaded. We
> already have standalone cluster mode.
> {code}
> high-availability: NONE // No HA
> high-availability: ZOOKEEPER // HA via ZooKeeper
> {code}
> The {{recovery.mode}} configuration keys would have to be deprecated before
> completely removing them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
