hehuiyuan commented on code in PR #19423:
URL: https://github.com/apache/flink/pull/19423#discussion_r849021129
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveGenericUDAF.java:
##########
@@ -105,6 +108,8 @@ private void init() throws HiveException {
GenericUDAFEvaluator.Mode.FINAL,
new ObjectInspector[] {partialResultObjectInspector});
+ isArgsSingleArray = HiveFunctionUtil.isSingleBoxedArray(argTypes);
Review Comment:
for (DataType dataType : argTypes) {
if (HiveFunctionUtil.isPrimitiveArray(dataType)) {
throw new FlinkHiveUDFException(
"Flink doesn't support primitive array for Hive
functions yet.");
}
}
Array(Double) is PrimitiveArray , throws exception.
Do you know why primiteive array is not supported?
There are some problems with `isArgsSingleArray` condition .
if argsType is Array then need the code `inputs = new Object[] {inputs}`;
if argsType is not Array then don't need the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
