luoyuxia commented on code in PR #19423:
URL: https://github.com/apache/flink/pull/19423#discussion_r849325810


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveGenericUDAF.java:
##########
@@ -105,6 +108,8 @@ private void init() throws HiveException {
                         GenericUDAFEvaluator.Mode.FINAL,
                         new ObjectInspector[] {partialResultObjectInspector});
 
+        isArgsSingleArray = HiveFunctionUtil.isSingleBoxedArray(argTypes);

Review Comment:
   Thanks, I see you.
   Actually, I don't know why primiteive array is not supported. It's legacy 
code I have no knowledge.
   According to my insight and test with Hive's qtest.  it should be supported. 
I think the validation can be droped.
   But currently, I would like to keep it and then see what will happen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to