hehuiyuan commented on code in PR #19423:
URL: https://github.com/apache/flink/pull/19423#discussion_r849197591
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveGenericUDAF.java:
##########
@@ -105,6 +108,8 @@ private void init() throws HiveException {
GenericUDAFEvaluator.Mode.FINAL,
new ObjectInspector[] {partialResultObjectInspector});
+ isArgsSingleArray = HiveFunctionUtil.isSingleBoxedArray(argTypes);
Review Comment:
I think we should determine whether the argTypes is Array , replace
primitive Array type.`
If argsType is Array , inputs should be converted to an object[].
If argsType is not Array, we can keep origin code logic.
`HiveFunctionUtil.isSingleBoxedArray(argTypes);` throws exception when
argTypes is Array and the elemet type is BOOLEAN | TINYINT | SMALLINT |
INTEGER | BIGINT | FLOAT | DOUBLE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
