snuyanzin commented on code in PR #19753:
URL: https://github.com/apache/flink/pull/19753#discussion_r876419257
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/TypeStrategiesTestBase.java:
##########
@@ -42,26 +40,36 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** Base class for tests of {@link TypeStrategies}. */
-@RunWith(Parameterized.class)
public abstract class TypeStrategiesTestBase {
- @Parameter public TestSpec testSpec;
-
- @Test
- public void testTypeStrategy() {
+ @ParameterizedTest(name = "{index}: {0}")
+ @MethodSource(
+ value = {
+
"org.apache.flink.table.types.inference.strategies.ArrayTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.CurrentWatermarkTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.DecimalTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.GetTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.MapTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.MappingTypeStrategiesTest#testData",
+
"org.apache.flink.table.types.inference.strategies.RowTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.StringConcatTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.TypeStrategiesTest#testData"
+ })
Review Comment:
seems resolved with test overriding
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/InputTypeStrategiesTestBase.java:
##########
@@ -45,39 +44,49 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** Base class for testing {@link InputTypeStrategy}. */
-@RunWith(Parameterized.class)
public abstract class InputTypeStrategiesTestBase {
- @Parameterized.Parameter public TestSpec testSpec;
-
- @Test
- public void testStrategy() {
+ @ParameterizedTest(name = "{index}: {0}")
+ @MethodSource(
+ value = {
+
"org.apache.flink.table.types.inference.ComparableInputTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.CurrentWatermarkInputTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.InputTypeStrategiesTest#testData",
+
"org.apache.flink.table.types.inference.strategies.RepeatingSequenceInputTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.SubsequenceInputTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.SymbolArgumentTypeStrategyTest#testData",
+
"org.apache.flink.table.types.inference.strategies.TypeLiteralArgumentTypeStrategyTest#testData"
+ })
Review Comment:
seems resolved with test overriding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
