snuyanzin commented on code in PR #19753:
URL: https://github.com/apache/flink/pull/19753#discussion_r876422680
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/ComparableInputTypeStrategyTest.java:
##########
@@ -33,24 +33,30 @@
import org.apache.flink.table.types.logical.StructuredType;
import
org.apache.flink.table.types.logical.StructuredType.StructuredComparison;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
import javax.annotation.Nonnull;
import java.lang.reflect.Field;
import java.util.List;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
+import java.util.stream.Stream;
-import static java.util.Arrays.asList;
import static java.util.Collections.singletonList;
/** Tests for {@link ComparableTypeStrategy}. */
-public class ComparableInputTypeStrategyTest extends
InputTypeStrategiesTestBase {
+class ComparableInputTypeStrategyTest extends InputTypeStrategiesTestBase {
- @Parameterized.Parameters(name = "{index}: {0}")
- public static List<TestSpec> testData() {
- return asList(
+ @ParameterizedTest(name = "{index}: {0}")
+ @MethodSource("testData")
+ protected void testStrategy(TestSpec testSpec) {
+ super.testStrategy(testSpec);
+ }
Review Comment:
This allows to run parameterized tests with parameters generated in successor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
