zhuzhurk commented on code in PR #20082: URL: https://github.com/apache/flink/pull/20082#discussion_r910645522
########## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedSpeculativeExecutionVertex.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +/** + * {@code ArchivedSpeculativeExecutionVertex} is a readonly representation of {@link + * SpeculativeExecutionVertex}. + */ +public class ArchivedSpeculativeExecutionVertex extends ArchivedExecutionVertex { + + private static final long serialVersionUID = 1L; + + public ArchivedSpeculativeExecutionVertex(SpeculativeExecutionVertex vertex) { + super( + vertex.getParallelSubtaskIndex(), + vertex.getTaskNameWithSubtaskIndex(), + vertex.getCurrentExecutionAttempt().archive(), + getCopyOfExecutionHistory(vertex)); + } + + private static ExecutionHistory getCopyOfExecutionHistory(SpeculativeExecutionVertex vertex) { + final ExecutionHistory executionHistory = + ArchivedExecutionVertex.getCopyOfExecutionHistory(vertex); + + // add all the executions to the execution history except for the only admitted current + // execution Review Comment: Yes, `ArchivedExecutionVertex` will be created when requesting the current execution graph status details. It includes all the current executions, no matter in what state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
