zhuzhurk commented on code in PR #20082: URL: https://github.com/apache/flink/pull/20082#discussion_r910803633
########## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java: ########## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.jobmaster.LogicalSlot; +import org.apache.flink.runtime.taskmanager.TaskManagerLocation; +import org.apache.flink.util.concurrent.FutureUtils; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.stream.Collectors; + +import static org.apache.flink.runtime.execution.ExecutionState.FAILED; +import static org.apache.flink.runtime.execution.ExecutionState.FINISHED; +import static org.apache.flink.util.Preconditions.checkNotNull; +import static org.apache.flink.util.Preconditions.checkState; + +/** The ExecutionVertex which supports speculative execution. */ +public class SpeculativeExecutionVertex extends ExecutionVertex { + + private final Map<ExecutionAttemptID, Execution> currentExecutions; + + public SpeculativeExecutionVertex( + ExecutionJobVertex jobVertex, + int subTaskIndex, + IntermediateResult[] producedDataSets, + Time timeout, + long createTimestamp, + int maxPriorExecutionHistoryLength, + int initialAttemptCount) { + super( + jobVertex, + subTaskIndex, + producedDataSets, + timeout, + createTimestamp, + maxPriorExecutionHistoryLength, + initialAttemptCount); + + this.currentExecutions = new LinkedHashMap<>(); + this.currentExecutions.put(currentExecution.getAttemptId(), currentExecution); + } + + public boolean containsSources() { Review Comment: duplicated comment. ########## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java: ########## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.jobmaster.LogicalSlot; +import org.apache.flink.runtime.taskmanager.TaskManagerLocation; +import org.apache.flink.util.concurrent.FutureUtils; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.stream.Collectors; + +import static org.apache.flink.runtime.execution.ExecutionState.FAILED; +import static org.apache.flink.runtime.execution.ExecutionState.FINISHED; +import static org.apache.flink.util.Preconditions.checkNotNull; +import static org.apache.flink.util.Preconditions.checkState; + +/** The ExecutionVertex which supports speculative execution. */ +public class SpeculativeExecutionVertex extends ExecutionVertex { + + private final Map<ExecutionAttemptID, Execution> currentExecutions; + + public SpeculativeExecutionVertex( + ExecutionJobVertex jobVertex, + int subTaskIndex, + IntermediateResult[] producedDataSets, + Time timeout, + long createTimestamp, + int maxPriorExecutionHistoryLength, + int initialAttemptCount) { + super( + jobVertex, + subTaskIndex, + producedDataSets, + timeout, + createTimestamp, + maxPriorExecutionHistoryLength, + initialAttemptCount); + + this.currentExecutions = new LinkedHashMap<>(); + this.currentExecutions.put(currentExecution.getAttemptId(), currentExecution); + } + + public boolean containsSources() { + return getJobVertex().getJobVertex().containsSources(); + } + + public boolean containsSinks() { Review Comment: duplicated comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
