lincoln-lil commented on code in PR #20592:
URL: https://github.com/apache/flink/pull/20592#discussion_r948688414
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/LookupJoinHintOptions.java:
##########
@@ -64,17 +62,14 @@ private LookupJoinHintOptions() {}
public static final ConfigOption<Integer> ASYNC_CAPACITY =
key("capacity")
.intType()
- .defaultValue(
-
ExecutionConfigOptions.TABLE_EXEC_ASYNC_LOOKUP_BUFFER_CAPACITY
- .defaultValue())
+ .noDefaultValue()
Review Comment:
the former version has default value references to related
ExecutionConfigOptions, but will have incorrect behavior when users configured
the corresponding option (differs from default one), and not explicit
configured via hint, e.g.,
user set
```
'table.exec.async-lookup.output-mode': ALLOW_UNORDERED
```
and use a LOOKUP hint
```
LOOKUP('table'='dim1', 'async'='true', 'timeout'='300s')
```
the expected final options on lookup table 'dim1' should be
```
output-mode=ALLOW_UNORDERED,
timeout=300s,
buffer-capacity=100
```
but will be wrongly with default value in hint options here:
```
output-mode=ORDERED,
timeout=300s,
buffer-capacity=100
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
