[GitHub] [flink] lincoln-lil commented on a diff in pull request #20592: [FLINK-28987][table-planner] Fix incorrect async to sync lookup fallback path of LegacyTableSourceTable

[GitBox]

lincoln-lil commented on code in PR #20592:
URL: https://github.com/apache/flink/pull/20592#discussion_r948706335


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java:
##########
@@ -246,18 +254,23 @@ protected Transformation<RowData> 
createJoinTransformation(
         RowType tableSourceRowType = 
FlinkTypeFactory.toLogicalRowType(temporalTable.getRowType());
         RowType resultRowType = (RowType) getOutputType();
         validateLookupKeyType(lookupKeys, inputRowType, tableSourceRowType);
+        boolean isAsyncEnabled = null != asyncLookupOptions;
+        ResultRetryStrategy retryStrategy =
+                retryOptions != null ? retryOptions.toRetryStrategy() : null;
 
         UserDefinedFunction lookupFunction =
                 LookupJoinUtil.getLookupFunction(
                         temporalTable,
                         lookupKeys.keySet(),
                         planner.getFlinkContext().getClassLoader(),
-                        joinHintSpec,
-                        upsertMaterialize);
+                        isAsyncEnabled,
+                        retryStrategy);
         UserDefinedFunctionHelper.prepareInstance(config, lookupFunction);
 
         boolean isLeftOuterJoin = joinType == FlinkJoinType.LEFT;
-        boolean isAsyncEnabled = lookupFunction instanceof AsyncTableFunction;
+        if (isAsyncEnabled) {
+            assert lookupFunction instanceof AsyncTableFunction;

Review Comment:
   This never happens in runtime by design, but to prevent incorrectly changes 
in LookupJoinUtil#isAsyncLookup



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org