[GitHub] [flink] lincoln-lil commented on a diff in pull request #20592: [FLINK-28987][table-planner] Fix incorrect async to sync lookup fallback path of LegacyTableSourceTable

[GitBox]

lincoln-lil commented on code in PR #20592:
URL: https://github.com/apache/flink/pull/20592#discussion_r948708427


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/LookupJoinHintOptions.java:
##########
@@ -64,17 +62,14 @@ private LookupJoinHintOptions() {}
     public static final ConfigOption<Integer> ASYNC_CAPACITY =
             key("capacity")
                     .intType()
-                    .defaultValue(
-                            
ExecutionConfigOptions.TABLE_EXEC_ASYNC_LOOKUP_BUFFER_CAPACITY
-                                    .defaultValue())
+                    .noDefaultValue()

Review Comment:
   I'll add more tests in AsyncLookupOptionsTest to cover this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org