snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1034895369
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -123,18 +130,19 @@ public class KafkaSinkITCase extends TestLogger {
private SharedReference<AtomicBoolean> failed;
private SharedReference<AtomicLong> lastCheckpointedRecord;
- @ClassRule
+ @Container
public static final KafkaContainer KAFKA_CONTAINER =
createKafkaContainer(KAFKA, LOG)
.withEmbeddedZookeeper()
.withNetwork(NETWORK)
.withNetworkAliases(INTER_CONTAINER_KAFKA_ALIAS);
- @Rule public final SharedObjects sharedObjects = SharedObjects.create();
+ @RegisterExtension
+ public final SharedObjectsExtension sharedObjects =
SharedObjectsExtension.create();
- @Rule public final TemporaryFolder temp = new TemporaryFolder();
+ @TempDir public Path temp;
- @BeforeClass
+ @BeforeAll
public static void setupAdmin() {
Review Comment:
```suggestion
static void setupAdmin() {
```
could be package private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
