snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1034897981
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java:
##########
@@ -77,6 +77,7 @@
import static org.assertj.core.api.Assertions.assertThat;
/** Tests for the standalone KafkaWriter. */
+@Testcontainers
@ExtendWith(TestLoggerExtension.class)
public class KafkaWriterITCase {
Review Comment:
```suggestion
class KafkaWriterITCase {
```
could be package private
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterStateSerializerTest.java:
##########
@@ -29,7 +30,8 @@
* Tests for serializing and deserialzing {@link KafkaWriterState} with {@link
* KafkaWriterStateSerializer}.
*/
-public class KafkaWriterStateSerializerTest extends TestLogger {
+@ExtendWith(TestLoggerExtension.class)
Review Comment:
Using the `META-INF/services/org.junit.jupiter.api.extension.Extension` is
the better approach here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
