snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1034896581
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -158,7 +167,7 @@ public void setUp() throws ExecutionException,
InterruptedException, TimeoutExce
createTestTopic(topic, 1, TOPIC_REPLICATION_FACTOR);
}
- @After
+ @AfterEach
public void tearDown() throws ExecutionException, InterruptedException,
TimeoutException {
Review Comment:
```suggestion
void tearDown() throws ExecutionException, InterruptedException,
TimeoutException {
```
could be package private
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaTransactionLogITCase.java:
##########
@@ -49,19 +51,21 @@
import static org.assertj.core.api.Assertions.assertThat;
/** Tests for {@link KafkaTransactionLog} to retrieve abortable Kafka
transactions. */
-public class KafkaTransactionLogITCase extends TestLogger {
+@Testcontainers
+@ExtendWith(TestLoggerExtension.class)
Review Comment:
Using the `META-INF/services/org.junit.jupiter.api.extension.Extension` is
the better approach here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
