snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1034904171
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java:
##########
@@ -166,7 +167,8 @@ public void testReaderRegistrationTriggersAssignments()
throws Throwable {
}
}
- @Test(timeout = 30000L)
+ @Test
+ @Timeout(30000L)
Review Comment:
In junit5 default unit is seconds while in junit4 is millis.
Do we really need to set timeout for 30000 secs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
