snuyanzin commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1373724108
##########
.github/workflows/ci.yml:
##########
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
"MVN_DEPENDENCY_CONVERGENCE=-Dflink.convergence.phase=install
-Pcheck-convergence" >> $GITHUB_ENV
+ - name: "Disable archunit tests"
+ if: ${{ inputs.skip_archunit_tests }}
+ run: echo "MVN_ARCHUNIT_TESTS=-Dtest='!*ArchitectureTest'" >>
$GITHUB_ENV
Review Comment:
I tried similar settings locally like
`mvn -Dflink.version=1.18.0 -Dtest=\!*ArchitectureTest* clean install` and
for dirs without archunit tests it fails like
```
No tests were executed! (Set -DfailIfNoTests=false to ignore this error.)
```
then if we add mentioned flag to the command then surefire mixes integration
and non integration tests (looks like a bug on surefire side, which does not
happen without this flag). The problem is that there is for instance test
called `PackagingITCase` assuming that there is already a built jar... however
if surefire runs it together with default tests instead of integration then
this test fails
would be great if this is somehow covered here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
