zentol commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1381576332
##########
.github/workflows/ci.yml:
##########
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
"MVN_DEPENDENCY_CONVERGENCE=-Dflink.convergence.phase=install
-Pcheck-convergence" >> $GITHUB_ENV
+ - name: "Disable archunit tests"
+ if: ${{ inputs.skip_archunit_tests }}
+ run: echo "MVN_ARCHUNIT_TESTS=-Dtest='!*ArchitectureTest'" >>
$GITHUB_ENV
Review Comment:
> See my comment above -Dtest works as expected.
It doesn't. To be more explicit than @snuyanzin, this will fail in
flink-sql-connector-* modules. Naturally it works in the Cassandra repo because
it doesn't have a sql-connector module.
Surefire exclusions are the way to go, but we can't see these on the
command-line since it'd override the unit/it test separation setup in the
parent pom.
I'd suggest to add another property to the connector parent pom
`additionalExcludes`, which it adds do the surefire exclusions.
##########
.github/workflows/ci.yml:
##########
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
"MVN_DEPENDENCY_CONVERGENCE=-Dflink.convergence.phase=install
-Pcheck-convergence" >> $GITHUB_ENV
+ - name: "Disable archunit tests"
+ if: ${{ inputs.skip_archunit_tests }}
+ run: echo "MVN_ARCHUNIT_TESTS=-Dtest='!*ArchitectureTest'" >>
$GITHUB_ENV
Review Comment:
> See my comment above -Dtest works as expected.
It doesn't. To be more explicit than @snuyanzin, this will fail in
flink-sql-connector-* modules. Naturally it works in the Cassandra repo because
it doesn't have a sql-connector module.
Surefire exclusions are the way to go, but we can't set these on the
command-line since it'd override the unit/it test separation setup in the
parent pom.
I'd suggest to add another property to the connector parent pom
`additionalExcludes`, which it adds do the surefire exclusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
