snuyanzin commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1374298376
##########
.github/workflows/ci.yml:
##########
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
"MVN_DEPENDENCY_CONVERGENCE=-Dflink.convergence.phase=install
-Pcheck-convergence" >> $GITHUB_ENV
+ - name: "Disable archunit tests"
+ if: ${{ inputs.skip_archunit_tests }}
+ run: echo "MVN_ARCHUNIT_TESTS=-Dtest='!*ArchitectureTest'" >>
$GITHUB_ENV
Review Comment:
the idea which seems working at least for my setup with opensearch connector
is using `<include>`, `<exclude>` for surefire plugin and different profiles
like
```xml
<properties>
<exclude.tests>nothing-to-exclude</exclude.tests>
</properties>
...
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
...
</configuration>
<executions>
<execution>
<!--execute all the unit tests-->
<id>default-test</id>
<configuration>
<includes>
<include>${test.unit.pattern}</include>
</includes>
<excludes>
<exclude>${exclude.tests}</exclude>
</excludes>
...
</configuration>
...
</execution>
<execution>
<!--execute all the integration tests-->
<id>integration-tests</id>
...
<configuration>
<includes>
<include>**/*.*</include>
</includes>
<excludes>
<exclude>${test.unit.pattern}</exclude>
<exclude>${exclude.tests}</exclude>
</excludes>
...
</configuration>
</execution>
</executions>
</plugin>
...
<profiles>
<profile>
<id>noArchUnit</id>
<properties>
<exclude.tests>**/org/apache/flink/architecture/**/*.java</exclude.tests>
</properties>
</profile>
</profiles>
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
