jnh5y commented on code in PR #23878:
URL: https://github.com/apache/flink/pull/23878#discussion_r1417448524
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json:
##########
@@ -81,19 +52,20 @@
},
"orderBy" : {
"fields" : [ {
- "index" : 0,
+ "index" : 2,
"isAscending" : true,
"nullIsLast" : false
} ]
},
"rankRange" : {
- "type" : "Variable",
- "endIndex" : 0
+ "type" : "Constant",
+ "start" : 1,
+ "end" : 1
},
"rankStrategy" : {
"type" : "AppendFast"
},
- "outputRowNumber" : true,
+ "outputRowNumber" : false,
Review Comment:
Let's see...
For RankProcessStrategy, the existing/ported tests only cover AppendFast.
(There are Undefined, Retract, and UpdateFast strategies.)
(I'm guessing that `generateUpdateBefore` is coupled with the strategy?)
For RankType, only ROW_NUMBER is covered. There is RANK, and DENSE_RANK.
For RankRange, we are testing having 1 and 2 rows... seems like that is
some reasonable coverage.
What is useful here? Adding coverage for the two (or three, if Undefined is
possible) `RankProcessStrategy`s and testing the other RankTypes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
