jnh5y commented on PR #23878: URL: https://github.com/apache/flink/pull/23878#issuecomment-1845326404
> lgtm > > Yes, it would be really nice if you could rebase it on top of current master. Cool. I've rebased the commits on to master. > My personal take is we should never merge master into PRs. It makes reasoning about what has changed really hard. Moreover, I don't know how will that work with squashing, rebasing and so on. I see github's doing some magic to exclude the merged changes, but I don't know how that works. Ayup, I can agree that linear git history is better. If the commits could be merge squashed, that takes care of everything. In this case, since we want to preserve two separate commits, I don't think things would work as nicely as we would like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
