jnh5y commented on code in PR #23878:
URL: https://github.com/apache/flink/pull/23878#discussion_r1417894843
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json:
##########
@@ -81,19 +52,20 @@
},
"orderBy" : {
"fields" : [ {
- "index" : 0,
+ "index" : 2,
"isAscending" : true,
"nullIsLast" : false
} ]
},
"rankRange" : {
- "type" : "Variable",
- "endIndex" : 0
+ "type" : "Constant",
+ "start" : 1,
+ "end" : 1
},
"rankStrategy" : {
"type" : "AppendFast"
},
- "outputRowNumber" : true,
+ "outputRowNumber" : false,
Review Comment:
As an update, RANK, and DENSE_RANK are not supported for streaming; I missed
that when reading initially.
The "Undefined" strategy is set before an actual strategy has been assigned.
I have added tests for the other two.
Let me know if you find anything else to cover and/or have any naming
suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
