MartijnVisser commented on code in PR #23489: URL: https://github.com/apache/flink/pull/23489#discussion_r1424285751
##########
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##########
@@ -188,6 +212,29 @@ under the License.
<goal>shade</goal>
</goals>
<configuration>
+ <filters>
+ <filter>
+
<artifact>org.apache.flink:flink-fs-hadoop-shaded</artifact>
+
<excludes>
+
<exclude>com/google/common/**</exclude>
+
<exclude>org/checkerframework/**</exclude>
+
<exclude>com/google/errorprone/**</exclude>
+
<exclude>com/google/j2objc/**</exclude>
+
<exclude>com/google/thirdparty/publicsuffix/**</exclude>
+
</excludes>
+ </filter>
+ <filter>
+
<artifact>*</artifact>
+
<excludes>
+
<exclude>properties.dtd</exclude>
+
<exclude>PropertyList-1.0.dtd</exclude>
+
<exclude>mozilla/**</exclude>
+
<exclude>META-INF/maven/**</exclude>
+
<exclude>META-INF/NOTICE.txt</exclude>
+
<exclude>META-INF/LICENSE.txt</exclude>
+
</excludes>
+ </filter>
+ </filters>
Review Comment:
We shouldn't exclude these dependencies during shading, but exclude them
from when we're adding the dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
