MartijnVisser commented on code in PR #23489: URL: https://github.com/apache/flink/pull/23489#discussion_r1425195367
########## flink-filesystems/flink-gs-fs-hadoop/pom.xml: ########## @@ -204,20 +251,13 @@ under the License. <pattern>org.apache.flink.runtime.util</pattern> <shadedPattern>org.apache.flink.fs.gs.org.apache.flink.runtime.util</shadedPattern> </relocation> + <!-- shade google guava version--> + <relocation> + <pattern>com.google.common</pattern> + <shadedPattern>org.apache.flink.fs.gs.com.google.common</shadedPattern> Review Comment: Yes but the code from GCS still expects the import to be `com.google.common` because it doesn't know about the shaded class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org