JingGe commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1854677694
Hi folks, thanks for driving it. @MartijnVisser my understanding is that your version won't work, since there still a `guava 27.0-jre` in the classpath. @singhravidutt: https://github.com/apache/flink/pull/23920 from @MartijnVisser actually shows the right direction. We don't need to exclude guava in `google-cloud-storage` and then build an explicit guava dependency. Afaik your version should also work but add extra effort of building guava dependency instead of leverage the dependency `google-cloud-storage` already has, i.e. if the next version of `google-cloud-storage` needs a new guava version, we have to change the guava dependency accordingly again and only a few people know it. I would suggest a solution combine your thoughts plus a small suggestion from me: 1. exclude guava in `flink-fs-hadoop-shaded ` thought from @singhravidutt 2. remove the new guava dependency created in this pom, thought from @MartijnVisser, 1+2 -> make sure there is no guava in the classpath 3. remove the exclude guava in `google-cloud-storage`, i.e. enable the gcs built-in guava dependency -> make sure `google-cloud-storage` has the right guava version in the classpath, thought from @MartijnVisser 4. remove the exclude guava in `org.apache.flink:flink-fs-hadoop-shaded` as I commented above. Please correct me if I am wrong. Look forward to your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
