Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2797
No, it's not just that one method. The method is on a whole other level; it
is so easy to edit a commit there simply is no reason for such a thing to exist
in the *initial PR*.
So, let's go through a few examples of purely cosmetic changes that could
easily have been moved into separate commit. These changes have absolutely no
bearing on the core of the PR, which is the port to the new state interface /
rescaling.
* Removing `State#hasBucketState`
* Addition, or rather full propagation of getPendingPathFor/etc. in the
entire class
* all the random small formatting changes; removing iniitializations to
null, generic parameters stuff, removing commas, adding missing spaces
* plenty small comment fixes
Note that these changes are all *good*, it was just be nice to separate
these *cosmetic* changes from the *functional* ones.
Now, let's talk about changes that are plain unnecessary and just noise:
* the modifications to reflectTruncate
* the loop change in snapshotState
* no longer storing the subtaskIndex in a field
* no longer looping over all buckets in restoreState (now
handleRestoredState)
With a properly cleaned diff i was able to determine very quickly what has
actually changed; and this was simply not possible in the current state of the
PR.
That is was I'm referring to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
