Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2797#discussion_r88125887
  
    --- Diff: 
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java
 ---
    @@ -70,7 +71,37 @@
        private static org.apache.hadoop.fs.FileSystem dfs;
        private static String hdfsURI;
     
    -   private OneInputStreamOperatorTestHarness<String, Object> 
createTestSink(File dataDir) throws Exception {
    +   private static final String PENDING_SUFFIX = ".pending";
    +   private static final String IN_PROGRESS_SUFFIX = ".in-progress";
    +   private static final String VALID_LENGTH_SUFFIX = ".valid";
    +
    +   private OneInputStreamOperatorTestHarness<String, Object> 
createRescalingTestSink(
    +           File outDir, int totalParallelism, int taskIdx, long 
inactivityInterval) throws Exception {
    +
    +           BucketingSink<String> sink = new 
BucketingSink<String>(outDir.getAbsolutePath())
    +                   .setBucketer(new Bucketer<String>() {
    +                           private static final long serialVersionUID = 1L;
    +
    +                           @Override
    +                           public Path getBucketPath(Clock clock, Path 
basePath, String element) {
    +                                   return new Path(basePath, element);
    +                           }
    +                   })
    +                   .setWriter(new StringWriter<String>())
    +                   .setInactiveBucketCheckInterval(inactivityInterval)
    +                   .setInactiveBucketThreshold(inactivityInterval)
    +                   .setPartPrefix("part")
    --- End diff --
    
    this should also be moved into a field since we use it in checkFS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to