Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2797#discussion_r88127261
  
    --- Diff: 
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkFaultTolerance2ITCase.java
 ---
    @@ -61,6 +62,10 @@
     * high. This provokes the case that the sink restarts without any 
checkpoint having been performed.
     * This tests the initial cleanup of pending/in-progress files.
     */
    +
    +// I suggest to remove this as we no longer clean up lingering files.
    +
    +@Ignore
     public class BucketingSinkFaultTolerance2ITCase extends 
StreamFaultToleranceTestBase {
    --- End diff --
    
    according to the javadocs we can indeed remove this test. Even without 
that, i can't quite figure out where the test actually verified that the files 
were deleted :/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to