libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1889182758
@snuyanzin My rough idea is like: * Pass `resolvedPredicates` and `pushdownParams` to `JdbcRowDataLookupFunction` * `FieldNamedPreparedStatement` may be need to adapt to allow pass additional predicates * set params to additional predicates somewhere, maybe after `lookupKeyRowConverter.toExternal` My goal is to keep current `ParameterizedPredicate` and `JdbcFilterPushdownPreparedStatementVisitor` unchanged, and adapt `JdbcRowDataLookupFunction` just like how we did for `JdbcRowDataInputFormat`. The challenge is how to make it work with `FieldNamedPreparedStatement` now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
