davidradl commented on PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1892371486
@libenchao @snuyanzin Hi , I have done some more local testing. It seems
that the fix as-is does not work with
1- lookup up join with a `?` in the join key
2- lookup up join with no filters but with a RDB column name containing a `?`
3- lookup up join with filters referencing a RDB column name containing a `?`
fyi scan queries seem to work, I tested :
- non-joining queries work with column names with `?`s in them.
- non-temporal joins with no filters , but with with column names with `?`s
in it.
- non-temporal joins with a filter specifying a column name with a `?`s in
it.
Note before the fix, the following fails.
1- lookup up join with a `?` in the join key
2- lookup up join with no filters but with a RDB column name containing a `?`
It looks like there are 2 issues for lookup joins, firstly that the filters
are ignored, the second is that `?` character does not work in column names or
lookup keys.
I hope an approach based on `FieldNamedPreparedStatement ` will resolve both
these issues. I am happy to be involved with the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
