gyfora commented on code in PR #755:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1452334612
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends
CommonStatus<FlinkDeploymentSpec> {
/** Information about the TaskManagers for the scale subresource. */
private TaskManagerInfo taskManager;
+
+ /** Last observed generation of the FlinkDeployment. */
+ private Long observedGeneration;
Review Comment:
Exactly as @mxm said.
Also the field inside the last reconciled spec has a slightly different and
more correct semantics. I think what you did here (update the observed
generation) doesn't make too much practical sense as the operator may fail
before even seeing the spec.
I see the value of having a top level `observedGeneration` field but it
should replace the current field hidden inside the lastReconciledSpec with the
same semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
