gyfora commented on code in PR #755:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1457356337
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends
CommonStatus<FlinkDeploymentSpec> {
/** Information about the TaskManagers for the scale subresource. */
private TaskManagerInfo taskManager;
+
+ /** Last observed generation of the FlinkDeployment. */
+ private Long observedGeneration;
Review Comment:
I think you misunderstand. Let's leave the `generation` field in the
lastReconciledSpec where it is now for backward compatibility.
However instead of getting it from there and setting it in the top level
status, set it in the top level status in the same step where we set in the
lastReconciledSpec. That way the next person doesn't have to rewrite the entire
logic to remove the deprecated meta field from lastReconciledSpec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
