justin-chen commented on code in PR #755:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1452942179


##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends 
CommonStatus<FlinkDeploymentSpec> {
 
     /** Information about the TaskManagers for the scale subresource. */
     private TaskManagerInfo taskManager;
+
+    /** Last observed generation of the FlinkDeployment. */
+    private Long observedGeneration;

Review Comment:
   Thanks for the guidance - I've added `observedGeneration` to `CommonStatus` 
class and set it alongside the `lastReconciledSpec`. I've left the `generation` 
within the `lastReconciledSpec` intact in case there are existing client 
dependencies on it. Let me know about any additional changes to be made



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to