justin-chen commented on code in PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1458380663
########## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java: ########## @@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends CommonStatus<FlinkDeploymentSpec> { /** Information about the TaskManagers for the scale subresource. */ private TaskManagerInfo taskManager; + + /** Last observed generation of the FlinkDeployment. */ + private Long observedGeneration; Review Comment: 👍 I have updated the PR to set `status.observedGeneration` using the [same source of truth](https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/reconciler/ReconciliationMetadata.java#L44) as `status.reconciliationStatus.lastReconciledSpec.resource_metadata.generation`, such that we can later remove the latter field without the `observedGeneration` depending on it. The new field is set in `updateStatusForSpecReconciliation` method alongside the `lastReconciledSpec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org