gyfora commented on code in PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1500903357
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -225,10 +227,14 @@ Map<JobVertexID, ScalingSummary> computeScalingSummary(
} else {
var currentParallelism =
(int)
metrics.get(ScalingMetric.PARALLELISM).getCurrent();
+
+ final boolean hasKeyBy =
+
jobTopology.get(v).getInputs().containsValue("HASH");
Review Comment:
It's a bit strange to check string values like `HASH` can we make this an
enum so that it's more explicit in the autoscaler code and easier to handle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
