gyfora commented on code in PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1501648975
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -225,10 +228,14 @@ Map<JobVertexID, ScalingSummary> computeScalingSummary(
} else {
var currentParallelism =
(int)
metrics.get(ScalingMetric.PARALLELISM).getCurrent();
+
+ final boolean hasKeyBy =
+
jobTopology.get(v).getInputs().containsValue(HASH);
Review Comment:
I assume this also means that sources are also not adjusted which can lead
to partition imbalance for Kafka topics. We should either keep the adjustments
for sources or remove the whole partition number querying/max parallelism logic
that we have during collection.
Overall I think for sources this makes sense and if we want to remove it
that should be a separate ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
