1996fanrui commented on code in PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1501752635
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -225,10 +228,14 @@ Map<JobVertexID, ScalingSummary> computeScalingSummary(
} else {
var currentParallelism =
(int)
metrics.get(ScalingMetric.PARALLELISM).getCurrent();
+
+ final boolean hasKeyBy =
+
jobTopology.get(v).getInputs().containsValue(HASH);
Review Comment:
Thanks a lot for pointing it out. I forgot it before.
I have updated. The source can adjust parallelism for now. Also, I updated
parameter names and the comment for `JobVertexScaler#scale` method, for exampe:
changing the numKeyGroups to maxParallelism, and changing hasKeyBy to
adjustByMaxParallelism.
Because the numKeyGroups and hasKeyBy aren't exactly for source vertex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
