1996fanrui commented on code in PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1502421187
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java:
##########
@@ -245,50 +247,69 @@ private boolean detectIneffectiveScaleUp(
}
}
+ /**
+ * Compute newParallelism according to currentParallelism.
+ *
+ * @param currentParallelism The current parallelism.
+ * @param maxParallelism The max parallelism for job vertices. It's
numKeyGroups by default, and
+ * it's partition number for kafka source vertex.
+ * @param scaleFactor The scale factor.
+ * @param parallelismLowerLimit The parallelism lower limitation in
autoscaler option.
+ * @param parallelismUpperLimit The parallelism upper limitation in
autoscaler option.
+ * @param adjustByMaxParallelism True means we need to adjust parallelism
according to the
+ * maxParallelism to ensure the keyGroup or partition evenly.
+ */
Review Comment:
I updated the comment for this method, please help check again in your free
time, thanks~
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/ShipStrategy.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.autoscaler.topology;
+
+import javax.annotation.Nonnull;
+
+/** The ship strategy between 2 JobVertices. */
+public enum ShipStrategy {
Review Comment:
I checked the `ShipStrategyType` just now, I found it's different with our
requirement. For example, ShipStrategyType has `PARTITION_FORCED_REBALANCE`
instead of `REBALANCE`.
As you said before, current ship-strategy comes from the toString, so IIUC
flink repo doesn't have corresponding enum so far. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
