afedulov commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1898962144


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1029,6 +1029,11 @@ private TableResultInternal executeInternal(
                         defaultJobName,
                         jobStatusHookList);
         try {
+            // Current context class loader here is the application class 
loader.

Review Comment:
   Just to be clear - 2.0 can introduce breaking changes. 1.19.x can't.



##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1029,6 +1029,11 @@ private TableResultInternal executeInternal(
                         defaultJobName,
                         jobStatusHookList);
         try {
+            // Current context class loader here is the application class 
loader.

Review Comment:
   Just to be clear - 2.0 can introduce breaking changes. 1.19.x can't.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to