ammu20-dev commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1896689787
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1029,6 +1029,11 @@ private TableResultInternal executeInternal(
defaultJobName,
jobStatusHookList);
try {
+ // Current context class loader here is the application class
loader.
Review Comment:
@afedulov The expected class loader here is the child class loader
FlinkUserCodeClassLoader for resolving dependencies related to external jars. I
can see that after
https://github.com/apache/flink/commit/64cbcd2d4b360f03f7964edece6f3211d184fb06
the class loader which is invoked here is the FlinkUserCodeClassLoader. Also
verified that the changes introduced here is not breaking the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
