ammu20-dev commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1896681057
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1542,6 +1542,21 @@ void testUsingAddJar() throws Exception {
"drop function lowerUdf");
}
+ @Test
+ void testUsingAddJarWithCheckpointing() throws Exception {
+ env().enableCheckpointing(100);
+ tEnv().executeSql(String.format("ADD JAR '%s'", jarPath));
+ ClassLoader contextClassLoader =
Thread.currentThread().getContextClassLoader();
+ testUserDefinedFunctionByUsingJar(
+ env ->
+ env.executeSql(
+ String.format(
+ "create function lowerUdf as '%s'
LANGUAGE JAVA",
+ udfClassName)),
+ "drop function lowerUdf");
+
assertThat(contextClassLoader.equals(Thread.currentThread().getContextClassLoader()));
+ }
Review Comment:
I haven't performed a git bisect while analysis and it was assumed by
checking the implementation done for
[FLINK-36065](https://issues.apache.org/jira/browse/FLINK-36065).
But now I performed a test on 2 different commit heads using this test case
for confirmation:
1.
https://github.com/apache/flink/commit/98f712640555333d5e1842a53441b283ca2f6e29
(before FLINK-36065) - test case fails.
2.
https://github.com/apache/flink/commit/64cbcd2d4b360f03f7964edece6f3211d184fb06
(after FLINK-36065) - test case succeeds.
<img width="1275" alt="image"
src="https://github.com/user-attachments/assets/fee2f4d5-8a47-48bd-8546-2363fbd51cc2";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
