[ 
https://issues.apache.org/jira/browse/FLINK-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744618#comment-15744618
 ] 

ASF GitHub Bot commented on FLINK-5325:
---------------------------------------

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/2992

    [FLINK-5325] Splitting user/system-facing API of CloseableRegistry

    Currently, the API of ``CloseableRegistry`` exposes the ``close`` method to 
all client code. This PR splits the API into a user-facing interface (allowing 
only for un/registration of ``Closeable`` and a system-facing part that also 
exposes the ``close method``. This prevents users from accidentally calling 
close, thus closing resources that other callers registered.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink 
closeable-registry-interface

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2992.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2992
    
----
commit fce3c97a575f4296d55bea2d833a4b55c0913ee4
Author: Stefan Richter <s.rich...@data-artisans.com>
Date:   2016-12-12T12:53:24Z

    [FLINK-5325] Splitting user/system-facing API of CloseableRegistry

----


> Introduce interface for CloseableRegistry to separate user from system-facing 
> functionality
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-5325
>                 URL: https://issues.apache.org/jira/browse/FLINK-5325
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> Currently, the API of {{CloseableRegistry}} exposes the {{close}} method to 
> all client code. We should separate the API into a user-facing interface 
> (allowing only for un/registration of {{Closeable}} and a system-facing part 
> that also exposes the {{close}} method. This prevents users from accidentally 
> calling {{close}}, thus closing resources that other callers registered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to